Added links to user docs inside About popup #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
requested changes
Jul 9, 2019
ghost
added
the
Needs-Author-Feedback
DHowett-MSFT
previously requested changes
Jul 9, 2019
ghost
removed
the
Needs-Author-Feedback
|
Should we make those link not selectable? |
zadjii-msft
approved these changes
Jul 10, 2019
src/cascadia/TerminalApp/App.cpp
Outdated
| @@ -185,6 +184,9 @@ namespace winrt::TerminalApp::implementation | |||
| auto resourceLoader = Windows::ApplicationModel::Resources::ResourceLoader::GetForCurrentView(); | |||
| const auto title = resourceLoader.GetString(L"AboutTitleText"); | |||
| const auto versionLabel = resourceLoader.GetString(L"VersionLabelText"); | |||
| const auto gettingStartedLabel = resourceLoader.GetString(L"GettingStartedLabelText\n"); | |||
There was a problem hiding this comment.
Wait does this work with the newline at the end of the key?
miniksa
requested changes
Jul 10, 2019
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
miniksa
approved these changes
Jul 11, 2019
miniksa
dismissed
DHowett-MSFT’s stale review
Because he said I could and Kayla satisfied his requests.
miniksa
added
the
AutoMerge
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
OK Kayla didn't move the last URI. But I did. And if the CI is good, then this is good. So automerge. |
ghost
merged commit
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
* added links into about section * added resources and aka.ms links * moved links to resources * Move the feedback URI into the resources too!
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added links to "Getting Started", "Documentation", and "Release Notes" in the About section.
References
#1576
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Clicked the links and they all work.
TODO
The hover color is too dark to read when using dark theme.