Prevent a crash on resizing too small caused by the Titlebar #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only set the MaxWidth of the TitlebarControl's Content when the value is positive. Any smaller will crash the app.
zadjii-msft
added
Issue-Bug
carlos-zamora
approved these changes
Jul 26, 2019
DHowett-MSFT
approved these changes
Jul 26, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Only set the MaxWidth of the TitlebarControl's Content when the value is
positive. Any smaller will crash the app.
PR Checklist
Validation Steps Performed
Opened the terminal with this fix and just went wild on the resize