Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default keybinding for opening dropdown #2365

Merged
8 commits merged into from
Aug 16, 2019
Merged

Add default keybinding for opening dropdown #2365

8 commits merged into from
Aug 16, 2019

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

Adds default keybinding of CtrlShiftSpace to open the dropdown menu.

References

PR Checklist

  • Closes New Tab Drop-down should be keyboard accessible #2181
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

CtrlShiftSpace will not close the dropdown menu if it has been opened. Do we want this functionality or is ESC sufficient?

Validation Steps Performed

@cinnamon-msft cinnamon-msft requested a review from a team August 8, 2019 21:09
zadjii-msft
zadjii-msft requested changes Aug 8, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I have some questions that I think I want answers on before I sign-off.

src/cascadia/TerminalApp/AppKeyBindings.idl Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/App.cpp Show resolved Hide resolved
src/cascadia/TerminalApp/App.cpp Show resolved Hide resolved
src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 8, 2019
carlos-zamora
carlos-zamora requested changes Aug 9, 2019
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge #2335 and add the new keybinding in too.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 9, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 9, 2019
zadjii-msft
zadjii-msft approved these changes Aug 9, 2019
View reviewed changes
src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved
@DHowett-MSFT
Copy link
Contributor

If this becomes the generic "menu" that we use for all user-configurable things it will no longer be just the "newTabDropdown". I'm not sure I carE? I dunno, the name seems too specific now.

@cinnamon-msft cinnamon-msft added the Needs-Second It's a PR that needs another sign-off label Aug 12, 2019
carlos-zamora
carlos-zamora approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think OpenNewTabDropdown is fine since it's the dropdown by the "new tab" button. Intuitive enough.

@DHowett-MSFT
Copy link
Contributor

/azp run

@DHowett-MSFT DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 14, 2019
@ghost
Copy link

ghost commented Aug 14, 2019

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@miniksa
Copy link
Member

miniksa commented Aug 16, 2019

I just merged master to this branch to unblock the static analysis build.

@ghost ghost requested a review from miniksa August 16, 2019 21:11
@ghost ghost merged commit d55ecae into master Aug 16, 2019
@ghost ghost deleted the cinnamon/dropdown-keybinding branch August 16, 2019 21:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa Awaiting requested review from miniksa

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Tab Drop-down should be keyboard accessible
5 participants
@cinnamon-msft @DHowett-MSFT @miniksa @carlos-zamora @zadjii-msft