Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Pane #2494

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Clean up Pane #2494

merged 4 commits into from
Aug 28, 2019

Commits on Aug 21, 2019

  1. Merge pane splitting methods 

    Having separate Horizontal/Vertical versions made it hard to manage, and App.cpp already made use of Pane::SplitState so it made sense to have that be the descriminator
    @richardszalay
    richardszalay committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    138fd3f View commit details
    Browse the repository at this point in the history

  2. Rename Tab::(Can)AddSplit to (Can)SplitPane to align with Pane methods 

    Split was used as a noun in Tab but a verb in Pane, which felt odd
    @richardszalay
    richardszalay committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    76ff685 View commit details
    Browse the repository at this point in the history

  3. Remove unused local variable in Pane::_CanSplit

    @richardszalay
    richardszalay committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    50d7e09 View commit details
    Browse the repository at this point in the history

  4. Remove redundant 'else' branches in Pane 

    Improves readibility. All 'low hanging fruit' cases where the 'if' was returning.
    @richardszalay
    richardszalay committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    a09a591 View commit details
    Browse the repository at this point in the history