GetGuid noexcept Fix #3806
Merged
GetGuid noexcept Fix #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No feedback from the Azure pipeline
Comment on lines
85
to
88
| catch (...) | ||
| { | ||
| LOG_CAUGHT_EXCEPTION(); | ||
| } |
There was a problem hiding this comment.
You should be able to replace this with CATCH_LOG(); I think.
There was a problem hiding this comment.
That makes sense. I thought something was off with this.
DHowett-MSFT
approved these changes
Dec 2, 2019
|
Wonder what the deal is with x86 build? Stalled out at unit testing. |
|
/azp run It happens sometimes 😄 |
|
Command 'run
It' is not supported by Azure Pipelines.
See additional documentation. |
|
really? /azp run |
|
Thanks for the re-run 🎉 |
ghost
requested review from
zadjii-msft
approved these changes
Dec 3, 2019
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixed the noexcept specifier on
GetGuid, and correctedFindProfileandFindGuidso they don't throw. Also, adjustedSettingsTeststo reflect these changes.References
PR Checklist
SettingsTestsDetailed Description of the Pull Request / Additional comments
The
noexceptspecifier onGetGuidwas not removed whenProfilewas updated tostd::optional<GUID>. This PR fixes that and modifies two helper functionsFindProfileandFindGuidinCascadiaSettingsto work correctly ifGetGuiddoes throw.Validation Steps Performed
Updated the
TestHelperFunctionstest group inSettingsTestsand made sure the tests pass.