Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix move focus between grouped panes (#3045) #3958

Merged
1 commit merged into from
Dec 16, 2019
Merged

Fix move focus between grouped panes (#3045) #3958

1 commit merged into from
Dec 16, 2019

Conversation

Daniel599
Copy link
Contributor

This PR fixes the ability to move between already-split panes

Summary of the Pull Request

PR Checklist

  • Closes Moving focus between panes doesn't always work #3045
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested manually.

@Daniel599
Copy link
Contributor Author

I couldn't find a place of automated tests for panes, is manual testing enough?

@zadjii-msft
Copy link
Member

I couldn't find a place of automated tests for panes, is manual testing enough?

😭 You don't even know how many hours I've spent working on unittests for Panes, to no avail. Manual testing is totally fine for this. Hopefully one day we'll have automated testing for them, but for now we have to deal with manual testing.

I'll probably pull this branch myself tomorrow Monday to check this out.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Dec 16, 2019
zadjii-msft
zadjii-msft approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely right, but I don't know why I had it like that originally. Maybe a typo? Doesn't look like there's any other errors like it in the codebase, so that's promising. Thanks for finding this!

@zadjii-msft zadjii-msft added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels Dec 16, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit dccb297 into microsoft:master Dec 16, 2019
@zadjii-msft zadjii-msft mentioned this pull request Dec 17, 2019
Open
59 tasks
@Daniel599 Daniel599 deleted the FixMoveFocusBetweenPanes branch December 17, 2019 20:49
@Daniel599
Copy link
Contributor Author

This is definitely right, but I don't know why I had it like that originally. Maybe a typo? Doesn't look like there's any other errors like it in the codebase, so that's promising. Thanks for finding this!

Glad I could help. Really like this product, and I love C++, so it's a win-win :)

@ghost
Copy link

ghost commented Jan 14, 2020

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 14, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@DHowett-MSFT DHowett-MSFT Awaiting requested review from DHowett-MSFT

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving focus between panes doesn't always work
3 participants
@Daniel599 @zadjii-msft @carlos-zamora