Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest MUX prerelease (2.3.191217003) #4024

Merged
1 commit merged into from
Dec 19, 2019

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Dec 19, 2019

Summary of the Pull Request

This latest MUX prerelease fixes the issue where the tab row wouldn't expand to fill the width of the window after shrinking the window size.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Thanks again @teaP for help fixing this

Validation Steps Performed

Launched the terminal, played with it a bit

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Dec 19, 2019
@DHowett-MSFT
Copy link
Contributor

Wow, and there's no other issues switching to 2.3?

@zadjii-msft
Copy link
Member Author

@DHowett-MSFT Sure didn't seem like there was...

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 19, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett-MSFT
Copy link
Contributor

FWIW: this isn't actually a prerelease in anything but name. It's a full normal build from their release branch, but in the mode that makes it put the DLLs into our package 😄

@miniksa
Copy link
Member

miniksa commented Dec 19, 2019

@msftbot wait 3 seconds before merging

@ghost
Copy link

ghost commented Dec 19, 2019

Hello @miniksa!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@miniksa
Copy link
Member

miniksa commented Dec 19, 2019

@msftbot don't wait to merge

@ghost
Copy link

ghost commented Dec 19, 2019

Hello @miniksa!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@miniksa
Copy link
Member

miniksa commented Dec 19, 2019

@msftbot go jump in a lake

@miniksa
Copy link
Member

miniksa commented Dec 19, 2019

@msftbot delay merging this pull request for 1 min

@ghost
Copy link

ghost commented Dec 19, 2019

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 19 Dec 2019 18:15:38 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit ae580e7 into master Dec 19, 2019
@ghost ghost deleted the dev/migrie/f/update-MUX-2.3.191217003 branch December 19, 2019 18:16
@ghost
Copy link

ghost commented Jan 14, 2020

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
3 participants