Trying to figure out x64 test failures, don't review

[miniksa]

Go away. You heard me.

[miniksa]

OK it passes with the 7 unit tests not including terminal core unit tests.

It hangs with terminal core unit tests added back to the set. Nnnn. Gotta dig in.

[miniksa]

2001.2914 passed right after I merged master in: https://dev.azure.com/ms/Terminal/_build/results?buildId=60613&view=results

Running again from this branch this time, not the merge branch
2001.2916: https://dev.azure.com/ms/Terminal/_build/results?buildId=60618&view=results

[miniksa]

2916 passed... Let's try one more with azp.

[miniksa]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[zadjii-msft]

Here's another 86 failure from #4403

---

This failure's certainly curious, in #4323 which really shouldn't affect the tests. It actually logs something:

  √ CopyOnSelect
  √ AltShiftKey
  √ AltSpace
  √ SetColorTableEntry
   [HRESULT 0x800706BE] A failure occurred while running a test operation: 'TerminalCoreUnitTests::ConptyRoundtripTests::WriteAFewSimpleLines'. (The process hosting the test code was unexpectedly terminated with exit code 0xC0000005 while invoking a test operation.)
  Stack Trace:
  at TerminalCoreUnitTests::ConptyRoundtripTests::WriteAFewSimpleLines() in :line -1
  Standard Output Messages:
 IsFalse(currentBuffer._IsAltBuffer())
 SUCCEEDED(currentBuffer.SetViewportOrigin(true, { 0, 0 }, true))
 AreEqual(COORD({ 0, 0 }), currentBuffer.GetTextBuffer().GetCursor().GetPosition())
 ***********	WriteAFewSimpleLines - Test Start		***********
 
 Write more lines of outout. We should use 
  to move the cursor
 IsNotNull(_pVtRenderEngine.get())
 IsGreaterThan(expectedOutput.size(), static_cast<size_t>(0)): writing="^[[2J", expecting 4 strings
 Expected =	"^[[2J"
 Actual =	"^[[2J"
 AreEqual(first.length(), cch)
 AreEqual(first, actualString)
 [HRESULT 0x800706BE] A failure occurred while running a test operation: 'TerminalCoreUnitTests::ConptyRoundtripTests::WriteAFewSimpleLines'. (The process hosting the test code was unexpectedly terminated with exit code 0xC0000005 while invoking a test operation.)
 
 ***********	WriteAFewSimpleLines - Test End		***********
 ***********	WriteAFewSimpleLines - Test Failed	***********
  √ TestSimpleBufferWriting
  √ TestDefaultColor
  √ TestDarkIndexColor

---

[miniksa]

idk man

[miniksa]

ok they're still failing. we need to figure out what or turn off the flaky tests as they're just getting in the way.

[zadjii-msft]

My theory is that it has to do with something that the ConptyRountripTests is instantiating that none of the tests before it was instantiating. Probably a Renderer, though it could be something else. I'd probably just make a test that does the METHOD_SETUP and METHOD_CLEANUP for those tests a bunch in a loop, and see if that will hang the tests.

[miniksa]

Closing this in favor of #4490 for now.