Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cursor in conpty correctly after a backspace when we've delayed an EOL wrap #4403

Merged
9 commits merged into from
Feb 11, 2020
Merged

Move cursor in conpty correctly after a backspace when we've delayed an EOL wrap #4403

9 commits merged into from
Feb 11, 2020

Commits on Jan 29, 2020

  1. This actually fixes this bug - different terminals EOL wrap different… 

    …ly, esp conhost v wt v gnome-terminal. Remove ambiguity - just hardcore move the cursor in this scenario.
    @zadjii-msft
    zadjii-msft committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    7fd5d51 View commit details
    Browse the repository at this point in the history

  2. Add some comments for PR

    @zadjii-msft
    zadjii-msft committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    9b6554b View commit details
    Browse the repository at this point in the history

  3. Try adding a test, but I can't get the test to repro the original beh… 

    …avior quite right
    @zadjii-msft
    zadjii-msft committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    0a98cce View commit details
    Browse the repository at this point in the history

  4. Revert "Try adding a test, but I can't get the test to repro the orig… 

    …inal behavior quite right"

This reverts commit 0a98cce.
    @zadjii-msft
    zadjii-msft committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    40b4966 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into dev/migrie/b/1245-I… 

    …-actually-did-it-this-time
    @zadjii-msft
    zadjii-msft committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    e0d251c View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. add a test for this particular case

    @zadjii-msft
    zadjii-msft committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    774b23b View commit details
    Browse the repository at this point in the history

  2. update comments

    @zadjii-msft
    zadjii-msft committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    6fcc52c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into dev/migrie/b/1245-I… 

    …-actually-did-it-this-time
    @zadjii-msft
    zadjii-msft committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    8a4a40f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/b/1245-I… 

    …-actually-did-it-this-time

# Conflicts:
#	src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp
    @zadjii-msft
    zadjii-msft committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    99efb5e View commit details
    Browse the repository at this point in the history