Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Automation Properties for TermControl #4732

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Feb 26, 2020

Summary of the Pull Request

Defines the following automation properties for a Terminal Control:

  • Orientation:
    • The orientation of the control
    • None --> Vertical
  • Name:
    • The name as used by assistive technology and other Microsoft UI Automation clients. Generally presented by automation clients as the primary way to identify an element (along with the control type)
    • "" --> <profile name>
  • HelpText:
    • The help text. Generally presented by automation clients if requested by the user. This would be something that you would normally expect to appear from tooltips.
    • "" --> <tab title>
  • LiveSetting:
    • reports the live setting notification behavior. A representation of how assertive this control should be when content changes.
    • none --> Polite

References

#2099 - Automation Properties for TerminalControl, Search Box
#2142 - Localization

PR Checklist

Detailed Description of the Pull Request / Additional comments

ProfileName had to be added to the TerminalSettings (IControlSettings) to pass that information along to the automation peer. In the rare event that somebody purposefully decided to make their ProfileName empty, we fallback to the tab title.

Validation Steps Performed

Verified using Accessibility Insights and inspect.exe

This is are some examples of the information a general user can expect to receive about a Terminal Control.

- Type: Terminal Control
- Name: Command Prompt
- Help Text (if requested): Command Prompt - ping bing.com
- Type: Terminal Control
- Name: Ubuntu
- Help Text (if requested): cazamor@PC-cazamor:/mnt/c/Users/cazamor$

Note, it is generally read by an automation client as follows:
"<type>, <name>"

@carlos-zamora carlos-zamora marked this pull request as ready for review February 27, 2020 17:33
@DHowett-MSFT DHowett-MSFT merged commit 74cd9db into master Feb 28, 2020
@DHowett-MSFT DHowett-MSFT deleted the dev/cazamor/acc/auto-props branch February 28, 2020 00:37
@DHowett-MSFT
Copy link
Contributor

Force-merged because filters files don't impact the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize Accessibility Resources
4 participants