Make Korean IME input more consistent #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonMSFT
added
Area-Input
ghost
requested review from
DHowett-MSFT
reviewed
Mar 4, 2020
|
@philnach if you've got a couple minutes, do you have any thoughts on this? |
…on't get confused and doubt myself
DHowett-MSFT
approved these changes
Mar 4, 2020
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
I've kicked just the x86 build to re-run; stand by. |
|
I believe this made emoji input do a weird thing: it only shows the most recently entered letter now |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Korean IME was not working correctly due to way we were clearing the input buffer inside of
TSFInputControl. We wanted to clear our input buffer and tell TSF to clear its input buffer as well when we receive aCompositionCompletedevent. This works fine in some IME languages such as Chinese and Japanese. However, Korean IME composes characters differently in such a way where we can't tell TSF to clear their buffer during aCompositionCompletedevent because it would clear the character that triggered theCompositionCompletedevent in the first place.The solution in this PR is to keep our
_inputBufferintact until the user presses Enter or Esc, in which case we clear our buffer and the TSF buffer. I've chosen these two keys because it seems to make sense to clear the buffer after text is sent to the terminal with Enter, and Esc usually means to cancel a current composition anyway.This means we need to keep track of our last known "Composition Start Point", which is represented by
_activeTextStart. Whenever we complete a composition, we'll send the portion of the input buffer between_activeTextStartand the end of the input buffer to the terminal. Then, we'll update_activeTextStartto be the end of the input buffer so that the next time we send text to the terminal, we'll only send the portion of our buffer that's "active".PR Checklist
Validation Steps Performed
Manual testing with Chinese, Japanese, and Korean IME.