-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Word Navigation/Selection Performance #4797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it. thanks
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Kicking the x86 to run that leg again |
While the performance of debug builds (i.e. just running |
@codeofdusk thank you for testing this out! |
@DHowett-MSFT @carlos-zamora As an aside, do you have an idea of when work on new text events for terminal (#2447) will start? Once implemented we can add support for Windows Terminal to NVDA. |
@codeofdusk I've been working on that now but I've been having trouble getting them to work (specifically for output). I'm able to fire a TextChanged event when new output appears, but I can't seem to understand how my UIA Providers are able to respond. Is it dependent on a setting on the XAML control? |
I'd think firing a text changed event would suffice, but I'm not quite sure. Could you send a test build/point me at a branch and I can explore with NVDA? Cc @michaelDCurran and @LeonarddeR for more detailed implementation suggestions. |
Sure! I'll send it in the morning and @ you three in #2447. Thank you so much! |
Summary of the Pull Request
Improves the performance of word-recognition operations such as word
navigation in UIA and selection.
Fixes a bug where attempting to find the next word in UIA, when none
exists, would hang
TraceLogging code only runs when somebody is listening
Detailed Description of the Pull Request / Additional comments
one text range. That is fixed now.
Validation Steps Performed
Performed Word Navigation under Narrator and NVDA.
NOTE: The release build should be used when testing to optimize
performance
Closes #4703