Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish AutomationProperties and UIA Tree Navigation #4805

Merged
8 commits merged into from
Mar 5, 2020
Merged

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Mar 4, 2020

AutomationProperties of interest in this PR include...

  • Name: the name of a UI element (generally used as the main identifier
    for it)
  • HelpText: an additional description for a more complex UI element
  • AccessibilityView[1]
    • Raw: hide from the UIA tree. Only navigate to this if you know what
      you're doing
    • Control: a control without any content in it. Basically, a point at
      which the user can make a decision as to how to navigate the tree or
      invoke an action.
    • Content: a control that also has content to present to the user.

I set a few more AutomationProperties throughout Windows Terminal...

  • MinMaxClose Control: hidden (we can/should rely on the true buttons
    that we are hiding)
  • SplitButton: Name and Help text (currently ignored due to Update AutomationProperties for SplitButton #4804, but
    having it in the resource file won't cause any problems)
  • SearchBox: added a more specific name to the close button
  • BackgroundImage: hide it

References

A few additional work items have been created for tracking...

PR Checklist

Validation Steps Performed

Verified using Accessibility Insights and Inspect.exe

[1] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-treeoverview

@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Mar 4, 2020
src/cascadia/TerminalControl/TermControl.xaml Outdated Show resolved Hide resolved
src/cascadia/TerminalControl/TSFInputControl.xaml Outdated Show resolved Hide resolved
@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 5, 2020
@ghost
Copy link

ghost commented Mar 5, 2020

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 27342db into master Mar 5, 2020
@ghost ghost deleted the dev/cazamor/acc/nav branch March 5, 2020 22:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Clean up UIA Tree Navigation Feature Request: Automation Properties
3 participants