Allow Emoji composition to be seen in the TSF TextBlock #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Mar 7, 2020
DHowett
approved these changes
Mar 7, 2020
DHowett-MSFT
approved these changes
Mar 7, 2020
|
I tested all four out again, all of them seem to work as expected 🤞 |
|
@leonMSFT does my boy "¯\_(ツ)_/¯" still work with the emoji picker too? |
zadjii-msft
added
the
Area-TerminalControl
|
ya boi ¯_( ͡° ͜ʖ ͡°)_/¯ is safe and sound |
|
oh no the arm got chopped off |
leonMSFT
added
the
AutoMerge
|
Hello @leonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Emoji composition was only being shown one letter at a time. This is because of the way I expected
CoreTextTextUpdatingEventArgs.Rangeto be provided to TSFInputControl during composition (for Chinese/Japanese IME). Emoji IME composition gives theStartCaretPositionas the same asEndCaretPosition, unlike how for Chinese/Japanese IME,StartCaretPositionis usually the start of the composition andEndCaretPositionis the latest character in the composition. The solution is to change the_inputBuffer.substr()call to simply grab all of the buffer starting from_activeTextStart. This way I can ensure that I grab all of the "active text", instead of trusting the givenargs.Rangeto tell me the active text.PR Checklist
Validation Steps Performed
Chinese, Japanese, Korean, Emoji composition performed. Emoji selection through pointer also performed.