Suppress run breaking for abs. differences < 0.001 in advance #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With certain font faces at certain sizes, the advances seem to be slightly more than the pixel grid; Cascadia Code at 13pt (though, 200% scale) had an advance of 10.000001. This commit makes it so that anything sub-1/100 of a cell won't make us break up runs, because doing so results in suboptimal rendering. Fixes #4806.
DHowett-MSFT
added
the
Area-Rendering
|
This does allow for a font to do a weird thing that makes the 100th character in a row be off by a whole cell, but why would it do that |
zadjii-msft
approved these changes
Mar 10, 2020
abhijeetviswam
pushed a commit
to abhijeetviswam/terminal
that referenced
this pull request
Mar 12, 2020
…oft#4861) With certain font faces at certain sizes, the advances seem to be slightly more than the pixel grid; Cascadia Code at 13pt (though, 200% scale) had an advance of 10.000001. This commit makes it so that anything sub-1/100 of a cell won't make us break up runs, because doing so results in suboptimal rendering. Fixes microsoft#4806.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With certain font faces at certain sizes, the advances seem to be
slightly more than the pixel grid; Cascadia Code at 13pt (though, 200%
scale) had an advance of 10.000001.
This commit makes it so that anything sub-1/100 of a cell won't make us
break up runs, because doing so results in suboptimal rendering.
Fixes #4806.
I wrote a renderer hack that colors text runs by their origin x (blue+) and y (red+).
This shows that at font size 12, we were only doing one run per line.
This shows that at font size 13, we were doing one run per cell.