-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process actions sync. on startup; don't dupe nonexistent profile #5090
Commits on Jan 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a8bd503 - Browse repository at this point
Copy the full SHA a8bd503View commit details -
You need to initialize a TerminalPage weirdly in the test, including _not_ checking App.Logic(), since the App doesn't have a Logic()
Configuration menu - View commit details
-
Copy full SHA for 648373d - Browse repository at this point
Copy the full SHA 648373dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 029b676 - Browse repository at this point
Copy the full SHA 029b676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6f72c - Browse repository at this point
Copy the full SHA 0a6f72cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9849fe9 - Browse repository at this point
Copy the full SHA 9849fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 963a830 - Browse repository at this point
Copy the full SHA 963a830View commit details
Commits on Mar 18, 2020
-
Merge branch 'master' into dev/migrie/b/2455-with-new-tests
# Conflicts: # src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp # src/cascadia/TerminalApp/TerminalPage.cpp
Configuration menu - View commit details
-
Copy full SHA for 8ed39cd - Browse repository at this point
Copy the full SHA 8ed39cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ad8bb - Browse repository at this point
Copy the full SHA 82ad8bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for eafe9c8 - Browse repository at this point
Copy the full SHA eafe9c8View commit details -
Try to clone the settings directly from the control
Okay this is harder, but maybe not impossible, but probably impossible in v1. The Profile knows how to build the connection settings, and the ControlSettings, etc. However, when the settings reloads like in this bug, we'll remove all the old profiles, and build a new list. If we wanted the case 1 behavior, we could wait until the Profile is a winrt object, then have each Pane hold a strong ref to the Profile that it's hosting. Then it would be trivial to be able to duplicate the settings from it. I believe that work is tracked in #3998. How palatable is doing case 3 now (to fix the crash), then filing a follow up to do case 1 once #3998 is done?
Configuration menu - View commit details
-
Copy full SHA for 908fd74 - Browse repository at this point
Copy the full SHA 908fd74View commit details -
Revert "I _think_ this will pull the settings from the control, but I…
… haven't tested yet" This reverts commit 82ad8bb.
Configuration menu - View commit details
-
Copy full SHA for 4561b9a - Browse repository at this point
Copy the full SHA 4561b9aView commit details -
Revert "Try to clone the settings directly from the control"
This reverts commit 908fd74.
Configuration menu - View commit details
-
Copy full SHA for 9eaee52 - Browse repository at this point
Copy the full SHA 9eaee52View commit details -
Configuration menu - View commit details
-
Copy full SHA for e952c0d - Browse repository at this point
Copy the full SHA e952c0dView commit details
Commits on Mar 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 07050b5 - Browse repository at this point
Copy the full SHA 07050b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bb6803 - Browse repository at this point
Copy the full SHA 4bb6803View commit details -
Configuration menu - View commit details
-
Copy full SHA for 499b003 - Browse repository at this point
Copy the full SHA 499b003View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95bb854 - Browse repository at this point
Copy the full SHA 95bb854View commit details -
Configuration menu - View commit details
-
Copy full SHA for a058181 - Browse repository at this point
Copy the full SHA a058181View commit details -
Configuration menu - View commit details
-
Copy full SHA for 998318a - Browse repository at this point
Copy the full SHA 998318aView commit details
Commits on Mar 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f3948d8 - Browse repository at this point
Copy the full SHA f3948d8View commit details -
Merge remote-tracking branch 'origin/master' into dev/migrie/b/pane-i…
…nitialization-order
Configuration menu - View commit details
-
Copy full SHA for 332a577 - Browse repository at this point
Copy the full SHA 332a577View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dffef4 - Browse repository at this point
Copy the full SHA 1dffef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2e45a9 - Browse repository at this point
Copy the full SHA e2e45a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 808868f - Browse repository at this point
Copy the full SHA 808868fView commit details -
This is a ton of colde cleanup ;
wtd split-pane
is broken, doesn't ……create the first tab :O
Configuration menu - View commit details
-
Copy full SHA for 6208f43 - Browse repository at this point
Copy the full SHA 6208f43View commit details -
Merge remote-tracking branch 'origin/master' into dev/migrie/b/pane-i…
…nitialization-order
Configuration menu - View commit details
-
Copy full SHA for 7e0685f - Browse repository at this point
Copy the full SHA 7e0685fView commit details -
this fixes just a bare
wt split-pane
; `wt; ; ; focus-tab -t 1; spli……t-pane` doesn't seem to work anymore
Configuration menu - View commit details
-
Copy full SHA for 09ab62a - Browse repository at this point
Copy the full SHA 09ab62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce2b948 - Browse repository at this point
Copy the full SHA ce2b948View commit details
Commits on Mar 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4306389 - Browse repository at this point
Copy the full SHA 4306389View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b3b517 - Browse repository at this point
Copy the full SHA 2b3b517View commit details -
Configuration menu - View commit details
-
Copy full SHA for e80ee31 - Browse repository at this point
Copy the full SHA e80ee31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd77e8 - Browse repository at this point
Copy the full SHA 9cd77e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7507f9f - Browse repository at this point
Copy the full SHA 7507f9fView commit details -
Merge remote-tracking branch 'origin/master' into dev/migrie/b/pane-i…
…nitialization-order
Configuration menu - View commit details
-
Copy full SHA for 60b2a49 - Browse repository at this point
Copy the full SHA 60b2a49View commit details
Commits on Mar 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 393492b - Browse repository at this point
Copy the full SHA 393492bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1c7f7e - Browse repository at this point
Copy the full SHA a1c7f7eView commit details
Commits on Mar 25, 2020
-
Merge remote-tracking branch 'origin/master' into dev/migrie/b/pane-i…
…nitialization-order
Configuration menu - View commit details
-
Copy full SHA for 1a15db3 - Browse repository at this point
Copy the full SHA 1a15db3View commit details -
Merge remote-tracking branch 'origin/master' into dev/migrie/b/pane-i…
…nitialization-order
1Configuration menu - View commit details
-
Copy full SHA for 34391c7 - Browse repository at this point
Copy the full SHA 34391c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3facb5 - Browse repository at this point
Copy the full SHA c3facb5View commit details