-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually pass mouse wheel messages to TermControls #5131
Merged
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
dae733a
try naively passing the mouse event through, but that doesn't seem to…
zadjii 892bc58
doing this the right way still isn't right
zadjii b708a08
start working on manually plumbing the event through, but this feels …
zadjii 68ace1a
This is so dumb ; I love it
zadjii-msft 7252ab6
Hey if your laptop's clock batttery is broken, you're going to have I…
zadjii-msft b3da428
Boy this is such a dirty hack but hey it works
zadjii-msft cf9d172
So very much code cleanup
zadjii-msft b5a6de3
Merge remote-tracking branch 'origin/master' into dev/migrie/b/979-hp…
zadjii-msft 47f8591
runformat
zadjii-msft 10cb133
Appease the spelling god?
zadjii-msft 52c94dc
fix the SA build
zadjii-msft 6e33a0f
this wasn't that scary
zadjii-msft c0ed7ea
this is a handy helper for converting between the two
zadjii-msft f3483c2
Some minor code cleanup to make things easier to read
zadjii-msft c7a1e77
some last changes for making events relative to the control origin
zadjii-msft 0de39a7
good bot
zadjii-msft 216941a
Merge remote-tracking branch 'origin/master' into dev/migrie/b/979-hp…
zadjii-msft 8c3e284
Wrap these exceptions up
zadjii-msft ff021e0
This wasn't supposed to be on this branch
zadjii-msft 10e7baa
Update src/cascadia/TerminalControl/TermControl.cpp
zadjii-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
namespace Microsoft.Terminal.TerminalControl | ||
{ | ||
|
||
// This interface is a hack for GH#979. Controls should implement this | ||
// interface to be able to be notified of mousewheel events even on devices | ||
// who's trackpads won't scroll inactive windows. | ||
|
||
[uuid("65b8b8c5-988f-43ff-aba9-e89368da1598")] | ||
interface IMouseWheelListener | ||
{ | ||
Boolean OnMouseWheel(Windows.Foundation.Point coord, Int32 delta); | ||
} | ||
zadjii-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we file a CodeHealth issue to replace this when the XAML Islands bug gets fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I just filed microsoft/microsoft-ui-xaml#2172 upstream to track them, I'll add another on us.