Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying wrapped lines by implementing better scrolling #5181

Merged
51 commits merged into from
Apr 9, 2020
Merged

Fix copying wrapped lines by implementing better scrolling #5181

Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
4bbb63d
Add tracing for circling and scrolling operations. Fix improper inval…
miniksa Mar 25, 2020
a543b1f
PR feedback applied. Don't bother making string if no one is listenin…
miniksa Mar 25, 2020
9ba2c69
More tracing is always good
zadjii-msft Mar 25, 2020
f10edc0
Merge remote-tracking branch 'origin/dev/miniksa/tmux_draw' into dev/…
zadjii-msft Mar 26, 2020
d42f960
So this works but I think it will break the EOL backspace test
zadjii-msft Mar 26, 2020
22bdf9b
This can't possibly be right... can it?
zadjii-msft Mar 26, 2020
466e8fc
mysteriously the existing tests all basically pass
zadjii-msft Mar 26, 2020
248d223
this is a simple test for the case that already worked
zadjii-msft Mar 26, 2020
b94cfdb
This test failure helps explain that this doesn't work
zadjii-msft Mar 26, 2020
e21101b
This all wroks far to shockingly well
zadjii-msft Mar 26, 2020
cf1145c
Add a test for this case
zadjii-msft Mar 26, 2020
2665b4c
this fixes this test, but maybe the test was always broken?
zadjii-msft Mar 27, 2020
2a0cc20
I'm honestly shocked that this seems to work
zadjii-msft Mar 27, 2020
870f052
Merge remote-tracking branch 'origin/master' into dev/migrie/b/5113-w…
zadjii-msft Mar 27, 2020
51f060e
cleanup for review, but I have to wait for #5122 to merge first
zadjii-msft Mar 27, 2020
8ecfcec
Merge branch 'master' into dev/migrie/b/5113-with-miniksas-fix
zadjii-msft Mar 30, 2020
436335f
Fix the test @miniksa wrote for #5122
zadjii-msft Mar 30, 2020
022b01a
Merge branch 'master' into dev/migrie/b/5113-with-miniksas-fix
zadjii-msft Apr 1, 2020
ac85d43
pr nits from dustin
zadjii-msft Apr 1, 2020
465f8be
Merge branch 'master' into dev/migrie/b/5113-with-miniksas-fix
zadjii-msft Apr 1, 2020
d317b8b
pr nits from carlos
zadjii-msft Apr 1, 2020
707844d
add the failing test for the case Dustin described
zadjii-msft Apr 1, 2020
8b19fcb
Fix this case for @dhowett-msft
zadjii-msft Apr 1, 2020
b70aacd
good bot
zadjii-msft Apr 1, 2020
0cbcf1f
fix a typo
zadjii-msft Apr 1, 2020
1c9a16f
add a test for #5039
zadjii-msft Apr 1, 2020
c7e5a45
This is the test case that's actaully broken in #5039
zadjii-msft Apr 2, 2020
015844b
finish the test for #5039
zadjii-msft Apr 2, 2020
a939f7e
Update this test with more info from the discussion thread
zadjii-msft Apr 2, 2020
a1cd2c5
This is the latest testcase dustin found for me
zadjii-msft Apr 2, 2020
c39871b
Fix the bug that Dustin reported in the PR
zadjii-msft Apr 3, 2020
746a1c8
Frick forgot to save
zadjii-msft Apr 3, 2020
9ea3960
Spellcheck fixes, thanks to @jsoref
zadjii-msft Apr 3, 2020
12f9c82
Add more comments
zadjii-msft Apr 3, 2020
3495cad
Starting on working on fixing this bug, but I can't get a minimal rep…
zadjii-msft Apr 3, 2020
c0fb26f
This scratch application repros a similar bug, so I'm treating this a…
zadjii-msft Apr 3, 2020
812dc86
wait this test does work for the host
zadjii-msft Apr 3, 2020
87a1486
Add a real test for #5161 and fix the associated bug
zadjii-msft Apr 6, 2020
017f302
Merge branch 'dev/migrie/b/5161-mingw-vim-fix' into dev/migrie/b/5113…
zadjii-msft Apr 6, 2020
c7fd127
Fix the Xterm*Invalidate tests
zadjii-msft Apr 6, 2020
55f81bc
I really wish I could run this bot locally on save or _before_ pushing
zadjii-msft Apr 6, 2020
3137a3b
Revert scratch.exe
zadjii-msft Apr 6, 2020
b188629
Some nits from Dustin
zadjii-msft Apr 6, 2020
6f9bd9a
test commit please ignore
zadjii-msft Apr 8, 2020
45d9f06
Merge remote-tracking branch 'origin/master' into dev/migrie/b/5113-w…
zadjii-msft Apr 8, 2020
1cc1035
some PR feedback
zadjii-msft Apr 8, 2020
c111961
I guess I need this one too
zadjii-msft Apr 8, 2020
15a47d3
Add a test to cover the new case Dustin found
zadjii-msft Apr 8, 2020
5e167cd
Fix the bug that dustin found. 0% change spellcheck bot loves me
zadjii-msft Apr 8, 2020
efe4aaf
love me
zadjii-msft Apr 8, 2020
d5af8c6
This makes more sense
zadjii-msft Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/spell-check/patterns/patterns.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ https://(?:(?:www\.|)youtube\.com|youtu.be)/[-a-zA-Z0-9?&=]*
Scro\&ll
# selectionInput.cpp
:\\windows\\syste\b
TestUtils::VerifyExpectedString\(tb, L"[^"]+"
hostSm\.ProcessString\(L"[^"]+"
5 changes: 5 additions & 0 deletions .github/actions/spell-check/whitelist/alphabet.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
AAAAAAAAAA
zadjii-msft marked this conversation as resolved.
Show resolved Hide resolved
abcd
abcde
abcdef
Expand All @@ -8,6 +9,9 @@ abcdefghijk
abcdefghijklmnop
ABCDEFGHIJKLMNOPQRST
abcdefghijklmnopqrstuvwxyz
BBBBB
BBBBBBBBBB
CCCCCCCCCC
QQQQQ
QQQQQQQQQ
QQQQQQQQQQ
Expand All @@ -21,6 +25,7 @@ QWERTYUIOP
qwertyuiopasdfg
TTTTTTTTTTTTTTTTTTTTTTTTTT
VVVVVVVVVVVVVVVV
XXXXX
yyyy
ZAAZZ
ZABBZ
Expand Down
1 change: 1 addition & 0 deletions .github/actions/spell-check/whitelist/whitelist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2895,6 +2895,7 @@ ZCtrl
zd
zh
ZM
zsh
zu
zxcvbnm
zy
Loading