wpf: port selection changes from TermControl, add multi-click selection #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a lot of logic that could be shared between TC and WPF. That is not a discussion to be having before 1.0 😄 |
zadjii-msft
added
Area-Input
carlos-zamora
approved these changes
Apr 16, 2020
| const auto delta{ timestamp - _lastMouseClickTimestamp }; | ||
| if (point != _lastMouseClickPos || delta > _multiClickTime) | ||
| { | ||
| // exit early. This is a single click. |
There was a problem hiding this comment.
Suggested change
| // exit early. This is a single click. | |
| // This is a single click. |
There was a problem hiding this comment.
comment copied from TermControl; i may keep it.
ZoeyR
approved these changes
Apr 17, 2020
|
@ZoeyR so I was thinking about this. It looks like it uses |
|
(which does exist on w7, so.. fingers crossed) |
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This pull request ports #5096 to WpfTerminalControl, bringing it in line with the selection mechanics in Terminal. It also introduces double- and triple-click selection and makes sure we clear the selection when we resize.
Please read #5096 for more details.
Detailed Description of the Pull Request / Additional comments
This code is, largely, copy-and-pasted from TermControl with some updates to use
std::chronoandtil::point. I lovetil::point. A lot.Validation Steps Performed
Lots of manual selection.