Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the SGR implementation in AdaptDispatch #5758

Merged
merged 11 commits into from
May 8, 2020
Merged

Refactor the SGR implementation in AdaptDispatch #5758

merged 11 commits into from
May 8, 2020

Commits on May 5, 2020

  1. Get rid of unused legacy methods in ATTR_ROW and OutputCell.

    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    dbf25c4 View commit details
    Browse the repository at this point in the history

  2. Replace unnecessary usage of TextAttributeRun::SetAttributesFromLegac… 

    …y with SetAttributes.
    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    562bdec View commit details
    Browse the repository at this point in the history

  3. Replace unnecessary usage of TextAttribute::SetFromLegacy with TextAt… 

    …tribute constructor.
    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    aeb1c7f View commit details
    Browse the repository at this point in the history

  4. Add methods to the TextAttribute class to update attributes with less… 

    … dependence on internal details.
    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0f08581 View commit details
    Browse the repository at this point in the history

  5. Update SetColorTableEntry API to take XTerm indices and add correspon… 

    …ding GetColorTableEntry API.
    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    249003f View commit details
    Browse the repository at this point in the history

  6. Rewrite the AdaptDispatch::SetGraphicsRendition method with a simpler… 

    … implementation.
    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9534337 View commit details
    Browse the repository at this point in the history

  7. Update adapter tests to account for the changes to the ConGetSet API.

    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    3c96482 View commit details
    Browse the repository at this point in the history

  8. Remove all the APIs that aren't needed anymore.

    @j4james
    j4james committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ee517f6 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Add suggested comment changes and TODO note.

    @j4james
    j4james committed May 7, 2020
    Configuration menu
    Copy the full SHA
    1513de7 View commit details
    Browse the repository at this point in the history

  2. Add bitfield(s) and href to the apis dictionary.

    @j4james
    j4james committed May 7, 2020
    Configuration menu
    Copy the full SHA
    9252ea2 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Merge branch 'master' into refactor-sgr-dispatch

    @j4james
    j4james authored May 8, 2020
    Configuration menu
    Copy the full SHA
    a0dd0b6 View commit details
    Browse the repository at this point in the history