-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure caption controls "dim out" when window loses NC focus #7015
Conversation
😢 you could have just updated the existing pull request/asked for it to be reopened lol |
You haven't resolved the issues brought up in #6577. When you do, we'll reopen that one. It's not worthwhile to submit the same change without updates when the bot closes it because you haven't updated it :P |
Uhmm, please check again |
@DHowett I copied the description from that PR and edited it afterwards... |
Oh well, that didnt cross my mind lol...(and anyways, that thread has a lot of noise...) |
Oh, I see. Okay. We'll review this. Thanks/sorry! |
Sorry, I was busy studying for exams.😞😞 |
Hmm, how do I implement Do we even need a getter... |
Hey so I finally had a chance to loop back on this PR. Turns out, you're super close to getting this working right. I threw together the remaining bits in 9a77620 if you want to take a look - you should be able to merge them into your PR without much hassle. Thanks for the patience! |
@zadjii-msft Thanks a lot!😄
Thanks, but as I mentioned in the description, I can't compile the code to test. Code looks good😊.
Ohhh, I am not too sure about that😅. I only know the most trivial git commands and especially after the change of base branch, I am afraid I would mess up. So, if you could tell me exactly what commands I need to use, I would be extremely grateful 🙏🙏. |
Tried rebasing, failed miserably |
Hello frands, I gib smol code
Summary
Make the caption controls "dim out" when window loses focus
References
https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-ncactivate
#5881
#3025
PR Checklist
Detailed Description of the Pull Request / Additional comments
Added a handler for WM_NCACTIVATE to propagate the focus change to the Titlebar Control.
The unfocused color is set to ForegroundBaseLow
Validation Steps Performed
None
Typed code on phone, PC is too weak to compile the whole project.
Also, My combined knowledge of c++ and xaml is still miniscule, so please have mercy😅😅