Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure caption controls "dim out" when window loses NC focus #7015

Closed
wants to merge 6 commits into from

Conversation

AnuthaDev
Copy link
Contributor

@AnuthaDev AnuthaDev commented Jul 22, 2020

Hello frands, I gib smol code

Summary

Make the caption controls "dim out" when window loses focus

References

https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-ncactivate
#5881
#3025

PR Checklist

  • Applies to Epic: Fix remaining issues with non-client drawing #1625
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Added a handler for WM_NCACTIVATE to propagate the focus change to the Titlebar Control.

The unfocused color is set to ForegroundBaseLow

Validation Steps Performed

None
Typed code on phone, PC is too weak to compile the whole project.

Also, My combined knowledge of c++ and xaml is still miniscule, so please have mercy😅😅

@DHowett
Copy link
Member

DHowett commented Jul 22, 2020

😢 you could have just updated the existing pull request/asked for it to be reopened lol

@DHowett
Copy link
Member

DHowett commented Jul 22, 2020

You haven't resolved the issues brought up in #6577. When you do, we'll reopen that one. It's not worthwhile to submit the same change without updates when the bot closes it because you haven't updated it :P

@DHowett DHowett closed this Jul 22, 2020
@AnuthaDev
Copy link
Contributor Author

You haven't resolved the issues brought up in #6577. When you do, we'll reopen that one. It's not worthwhile to submit the same change without updates when the bot closes it because you haven't updated it :P

Uhmm, please check again

@AnuthaDev
Copy link
Contributor Author

@DHowett I copied the description from that PR and edited it afterwards...

@AnuthaDev
Copy link
Contributor Author

AnuthaDev commented Jul 22, 2020

😢 you could have just updated the existing pull request/asked for it to be reopened lol

Oh well, that didnt cross my mind lol...(and anyways, that thread has a lot of noise...)

@DHowett DHowett reopened this Jul 22, 2020
@DHowett
Copy link
Member

DHowett commented Jul 22, 2020

Oh, I see. Okay. We'll review this. Thanks/sorry!

@AnuthaDev
Copy link
Contributor Author

bot closes it because you haven't updated it :P

Sorry, I was busy studying for exams.😞😞

@AnuthaDev
Copy link
Contributor Author

AnuthaDev commented Jul 23, 2020

Hmm, how do I implement bool Focused() in the .cpp file?(using a private variable for focus state? I thought the idl enabled some sort of property access syntax...), I dont know c++, lol.😅😅

Do we even need a getter...

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main October 22, 2020 00:27
@zadjii-msft zadjii-msft self-assigned this Nov 5, 2020
zadjii-msft added a commit that referenced this pull request Nov 20, 2020
@zadjii-msft
Copy link
Member

Hey so I finally had a chance to loop back on this PR. Turns out, you're super close to getting this working right. I threw together the remaining bits in 9a77620 if you want to take a look - you should be able to merge them into your PR without much hassle.

Thanks for the patience!

@zadjii-msft zadjii-msft assigned AnuthaDev and unassigned zadjii-msft Nov 20, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Nov 20, 2020
@AnuthaDev
Copy link
Contributor Author

@zadjii-msft Thanks a lot!😄

I threw together the remaining bits in 9a77620 if you want to take a look

Thanks, but as I mentioned in the description, I can't compile the code to test. Code looks good😊.

you should be able to merge them into your PR without much hassle.

Ohhh, I am not too sure about that😅. I only know the most trivial git commands and especially after the change of base branch, I am afraid I would mess up.

So, if you could tell me exactly what commands I need to use, I would be extremely grateful 🙏🙏.

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 21, 2020
@AnuthaDev
Copy link
Contributor Author

Tried rebasing, failed miserably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants