wpf: Add AutoFill to control whether the connection/buffer resizes #7853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows that the container can host.
javierdlg
changed the title
miniksa
reviewed
Oct 8, 2020
miniksa
approved these changes
Oct 9, 2020
DHowett
changed the title
DHowett
changed the title
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
skyline75489
pushed a commit
to skyline75489/terminal
that referenced
this pull request
Oct 10, 2020
…icrosoft#7853) Adds the ability to manually handle the terminal renderer resizing events by allowing different render size and WPF control size. This is done by adding an `AutoFill` property to the control that prevents the renderer from automatically resizing and tells the WPF control to fill in the extra space with the terminal background as shown below: This PR adds the following: - Helper method in the DX engine to convert character viewports into pixel viewports - `AutoFill` property that prevents automatic resizing of the renderer - Tweaks and fixes that automatically fill in the empty space if `AutoFill` is set to false - Fixes resizing methods and streamlines their codepath ## Validation Steps Performed Manual validation with the Visual Studio Integrated Terminal tool window.
DHowett
pushed a commit
that referenced
this pull request
Oct 13, 2020
…7853) Adds the ability to manually handle the terminal renderer resizing events by allowing different render size and WPF control size. This is done by adding an `AutoFill` property to the control that prevents the renderer from automatically resizing and tells the WPF control to fill in the extra space with the terminal background as shown below: This PR adds the following: - Helper method in the DX engine to convert character viewports into pixel viewports - `AutoFill` property that prevents automatic resizing of the renderer - Tweaks and fixes that automatically fill in the empty space if `AutoFill` is set to false - Fixes resizing methods and streamlines their codepath ## Validation Steps Performed Manual validation with the Visual Studio Integrated Terminal tool window. (cherry picked from commit 9e86e29)
DHowett
pushed a commit
that referenced
this pull request
Oct 13, 2020
…7853) Adds the ability to manually handle the terminal renderer resizing events by allowing different render size and WPF control size. This is done by adding an `AutoFill` property to the control that prevents the renderer from automatically resizing and tells the WPF control to fill in the extra space with the terminal background as shown below: This PR adds the following: - Helper method in the DX engine to convert character viewports into pixel viewports - `AutoFill` property that prevents automatic resizing of the renderer - Tweaks and fixes that automatically fill in the empty space if `AutoFill` is set to false - Fixes resizing methods and streamlines their codepath ## Validation Steps Performed Manual validation with the Visual Studio Integrated Terminal tool window. (cherry picked from commit 9e86e29)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to manually handle the terminal renderer resizing
events by allowing different render size and WPF control size. This is
done by adding an
AutoFillproperty to the control that prevents therenderer from automatically resizing and tells the WPF control to fill
in the extra space with the terminal background as shown below:
This PR adds the following:
pixel viewports
AutoFillproperty that prevents automatic resizing of the rendererAutoFillis set to falseValidation Steps Performed
Manual validation with the Visual Studio Integrated Terminal tool
window.