Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash the URI as part of the hyperlink ID #7940

Merged
3 commits merged into from
Oct 16, 2020
Merged

Hash the URI as part of the hyperlink ID #7940

3 commits merged into from
Oct 16, 2020

Commits on Oct 16, 2020

  1. Hash the URI as part of the hyperlink ID 

    It turns out that we missed part of the OSC 8 spec which indicated that
_hyperlinks with the same ID but different URIs are logically distinct._

> Character cells that have the same target URI and the same nonempty id
> are always underlined together on mouseover.
> The same id is only used for connecting character cells whose URIs is
> also the same. Character cells pointing to different URIs should never
> be underlined together when hovering over.

This pull request fixes that oversight by appending the (hashed) URI to
the generated ID.

When Terminal receives one of these links over ConPTY, it will hash the
URL a second time and therefore append a second hashed ID. This is taken
as an acceptable cost.

Fixes #7698
    @DHowett
    DHowett committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    0008fc6 View commit details
    Browse the repository at this point in the history

  2. un-dumb the tests

    @DHowett
    DHowett committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    dc444e6 View commit details
    Browse the repository at this point in the history

  3. Update src/buffer/out/textBuffer.cpp

    @DHowett
    DHowett authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    39d467e View commit details
    Browse the repository at this point in the history