Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing on profile advanced page #8065

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Oct 27, 2020

When I did the polishing I forgot to do the Advanced page under profiles. I fixed that here.

@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

gimme up a good good screenshoot

Comment on lines +246 to +253
<CheckBox x:Uid="Profile_Hidden" Margin="0,0,0,20" FontSize="15" ToolTipService.Placement="Mouse" />
<CheckBox x:Uid="Profile_SuppressApplicationTitle" Margin="0,0,0,20" FontSize="15" ToolTipService.Placement="Mouse" />
<Controls:RadioButtons x:Uid="Profile_AntialiasingMode" Margin="0,0,0,20" FontSize="15" ToolTipService.Placement="Mouse">
<RadioButton x:Uid="Profile_AntialiasingModeGrayscale" x:Name="antialiasingTextGrayscale"/>
<RadioButton x:Uid="Profile_AntialiasingModeClearType" x:Name="antialiasingTextClearType"/>
<RadioButton x:Uid="Profile_AntialiasingModeAliased" x:Name="antialiasingTextAliased"/>
</Controls:RadioButtons>
<CheckBox x:Uid="Profile_AltGrAliasing" ToolTipService.Placement="Mouse" />
<CheckBox x:Uid="Profile_SnapOnInput" ToolTipService.Placement="Mouse" />
<Controls:NumberBox x:Uid="Profile_HistorySize" Margin="0,0,0,10" Value="9001" SpinButtonPlacementMode="Compact" SmallChange="10" LargeChange="100" ToolTipService.Placement="Mouse" />
<Controls:RadioButtons x:Uid="Profile_CloseOnExit" Margin="0,0,0,10" ToolTipService.Placement="Mouse">
<CheckBox x:Uid="Profile_AltGrAliasing" Margin="0,0,0,20" FontSize="15" ToolTipService.Placement="Mouse" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there some way for us to abstract these out? it seems silly to hardcode it 500 times...

@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

These build breaks are my fault; you can safely ignore them

@DHowett DHowett merged commit 22805bd into feature/settings-ui Oct 27, 2020
@DHowett DHowett deleted the cinnamon/profile-advanced/tweaks branch October 27, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants