Spec for Quake Mode

[zadjii-msft]

⇒ doc link ⇐

Summary of the Pull Request

After reading through 114+ comments in #653 and related issues, I think I've finally wrapped my head around all the possible scenarios for quake mode. This also includes "minimize to tray", because the two are a powerful combination. With the work already prototyped in dev/migrie/f/653-QUAKE-MODE, I'm starting to believe that we could actually land this in 2.0.

Abstract

Many existing terminals support a feature whereby a user can press a keybinding
anywhere in the OS, and summon their terminal application. Oftentimes the act of
summoning this window is accompanied by a "dropdown" animation, where the window
slides in to view from the top of the screen. This global summon action is often
referred to as "quake mode", a reference to the videogame Quake who's console
slid in from the top.

This spec addresses both of the following two issues:

• "Quake Mode" ([Feature request: hot key drop down ala quake/guake/tilda #653])
• "Minimize to tray" ([[Feature-request] Minimize to tray #5727])

PR Checklist

• Specs: Feature request: hot key drop down ala quake/guake/tilda #653, [Feature-request] Minimize to tray #5727
• References: Scenario: Windows Terminal 2.0 Process Model Improvements #5000, Add support for wt.exe to run commands in an existing Terminal Window #4472, Feature Request: Option to only allow one instance #2227, Spec for Windows Terminal Process Model 2.0 #7240, Spec for Windows Terminal Window Management #8135
• I work here

Detailed Description of the Pull Request / Additional comments

*^*_* read the spec _*^**

[skyline75489]

This would be the feature of the year to me. 🎉

I’ve been rocking with Quake mode since I was in college and using Linux Mint.

[skyline75489]

I gotta say "toCurrent" and "onCurrent" looks really alike. Perhaps "floating" & "fixed"? Or something like that. Same for the monitor setting.

[carlos-zamora]

Ok, I like that this gives you a way to see the names of the windows.

[carlos-zamora]

"Story G" doesn't get addressed by this spec, I think. This is also specifically how iTerm2 works and I feel like that's the mode that speaks most to me.

[zadjii-msft]

Isn't that "minimize to tray"?

[rlabrecque]

G could be separate from F. It just feels like a next step to it where you could add a setting to remove it from alt+tab, possibly regardless of whether it's single mode or not, or only if minimize to tray is enabled.

[zadjii-msft]

Alrighty @microsoft/windows-console-team, updated this with the results of the discussion Friday. _quake mode was added, because that sparks joy.

[donsingh]

Many other implementations of this in Windows always have an issue with z-index placements. Sometimes the terminal slides under a pinned window or is inconsistent with apps in full screen mode. Also when a window is checked "Show this on all desktops" mode in virtual workspaces mode, most tiling implementations fall under it.

I hope this is being considered as well. Im not familiar enough with the process to add storyboards the the readme.

[dferrante]

i'm really excited for this, this is a killer app for me

[dfyx]

One thing that's missing (or did I just not find it in the spec?) is automatically hiding a quake mode window when it loses focus which is something many implementations (for example ConEmu) offer. Of course this should be a configuration option.

[zadjii-msft]

One thing that's missing (or did I just not find it in the spec?) is automatically hiding a quake mode window when it loses focus which is something many implementations (for example ConEmu) offer. Of course this should be a configuration option.

That's a great idea, and I'll definitely throw something in the spec for that. Thanks!

[github-actions]

Misspellings found, please review:

• comitted

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"aspnet boostorg Cac COINIT dahall fde fea fmtlib isocpp mintty NVDA pinam QOL remoting unte vcrt what3words xamarin "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect/b8e36bae9f869c56caa56c1f9f6b071dac796d33.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling/expect";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"cac coinit comitted Remoting "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

• ... misspelled, then please correct them instead of using the command.
• ... names, please add them to .github/actions/spelling/dictionary/names.txt.
• ... APIs, you can add them to a file in .github/actions/spelling/dictionary/.
• ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
• ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

🗜️ If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the .github/actions/spelling/excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

[lhecker]

I somewhat feel like this spec tries to do too much. I'd personally prefer having a simpler spec initially and refining this feature later on. For instance I totally understand the need for the distinction between monitors and desktops, but I'm not sure how many people actually need that...

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.