Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for resource recursion problem #2778

Merged
merged 12 commits into from
May 2, 2024
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Apr 30, 2024

I can reliably reproduce with 3.3.1, but not with 3.4.0 anymore. I changed the test (coming from RunsToCompletionWhenJapaneseResourcesAreLookedUpForMSCorLib in vstest) to change culture in the same thread beacuse TestInitialize can have a different thread in newer versions of mstest. Still I cannot reproduce.

Fix #2692

@nohwnd nohwnd marked this pull request as ready for review April 30, 2024 08:24
@nohwnd nohwnd requested a review from Evangelink as a code owner April 30, 2024 08:24
…blyResolverTests.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
@Evangelink
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink
Copy link
Member

@nohwnd I have rerun a few times but it's always failing with no errors so I think something is going-on.

@Evangelink Evangelink enabled auto-merge (squash) May 2, 2024 11:01
@Evangelink Evangelink disabled auto-merge May 2, 2024 11:22
@Evangelink Evangelink merged commit 86252b7 into main May 2, 2024
2 of 6 checks passed
@Evangelink Evangelink deleted the add-test-for-recursion branch May 2, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursion resource resolve regresssion
2 participants