Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing dark colors #3825

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Fix writing dark colors #3825

merged 6 commits into from
Sep 13, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Sep 13, 2024

Fix writing dark colors as their bright counterpart.
Fix writing both grays as dark gray.

Fix #3821

@microsoft-github-policy-service microsoft-github-policy-service bot added Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Bug labels Sep 13, 2024
Evangelink
Evangelink previously approved these changes Sep 13, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we should invest in some kind of screenshot diff acceptance tests to avoid color regression (later).

@nohwnd
Copy link
Member Author

nohwnd commented Sep 13, 2024

@Evangelink, backport to previous version?

@Evangelink
Copy link
Member

@Evangelink, backport to previous version?

Yeah you will probably need to release 1.4.1 so backport to rel/1.4 (don't force merge yet, I need to bump versions)

@nohwnd nohwnd merged commit 82cecf0 into main Sep 13, 2024
6 checks passed
@nohwnd nohwnd deleted the fix-colors branch September 13, 2024 11:50
nohwnd added a commit that referenced this pull request Sep 13, 2024
MarcoRossignoli pushed a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark colors are printed incorrectly with FormattedTextOutputDeviceData
3 participants