-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix writing dark colors #3825
Fix writing dark colors #3825
Conversation
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
…es/launchSettings.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we should invest in some kind of screenshot diff acceptance tests to avoid color regression (later).
@Evangelink, backport to previous version? |
Yeah you will probably need to release |
191f038
Fix writing dark colors as their bright counterpart.
Fix writing both grays as dark gray.
Fix #3821