Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code fix for MSTEST0021 #3827

Merged
merged 20 commits into from
Nov 11, 2024
Merged

Add code fix for MSTEST0021 #3827

merged 20 commits into from
Nov 11, 2024

Conversation

engyebrahim
Copy link
Member

fix: #3665

@engyebrahim
added code fix
2699fd0
@engyebrahim
Merge branch 'main' into enji/code-fix-21
f9d50e0 
# Conflicts:
#	src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.Designer.cs
#	src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx
@engyebrahim
fix
917b442
@engyebrahim engyebrahim marked this pull request as ready for review September 23, 2024 13:29
MarcoRossignoli
MarcoRossignoli reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions for you and @Evangelink

Evangelink
Evangelink reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would need to look at roslyn and roslyn-analyzer code fixes but it feels wrong that we have to do all of these actions ourselves.

@Evangelink Evangelink enabled auto-merge (squash) November 11, 2024 13:51
@Evangelink Evangelink merged commit 7a39c34 into main Nov 11, 2024
6 checks passed
@Evangelink Evangelink deleted the enji/code-fix-21 branch November 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@MarcoRossignoli MarcoRossignoli MarcoRossignoli left review comments

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: Analyzers Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code fix for MSTEST0021
4 participants
@engyebrahim @MarcoRossignoli @Evangelink @Youssef1313