Fix localization of test adapter messages #3867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Sep 26, 2024
There was a problem hiding this comment.
netfx-netcore-netstandard folder is using CultureString instead of UICulture https://github.com/microsoft/testfx/blob/main/src/Adapter/MSTest.TestAdapter/build/netfx-netcore-netstandard/MSTest.TestAdapter.targets#L71. I am not sure if these should be unified.
Also uwp is having similar bug as net. Could you port the fix there too?
|
ah, I thought this is a common target that is used by all the tfms. will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the resource dlls into the correct localization folders for localized runs.
Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2221503?src=WorkItemMention&src-action=artifact_link