Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization info to avoid translating workers and scope #3869

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Sep 26, 2024

Other options say to not localize workers and scope, but not the banner.

@nohwnd nohwnd enabled auto-merge (squash) September 26, 2024 11:58
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the translations for languages I speak, I do agree that not translating these keywords is better. Thank you @nohwnd

@nohwnd nohwnd merged commit 257b83c into main Sep 26, 2024
7 checks passed
@nohwnd nohwnd deleted the fix-localization-2 branch September 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants