Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass name style policy to kotlin code generator #538

Merged

Conversation

rhappe
Copy link
Contributor

@rhappe rhappe commented Jul 26, 2023

This fix should make it so that the kotlin code generation respects the nameStyle option when using the gradle plugin.

Fixes #537

@codecov-commenter
Copy link

Codecov Report

Merging #538 (f480f1a) into master (7ee0951) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #538   +/-   ##
=========================================
  Coverage     59.43%   59.43%           
  Complexity      883      883           
=========================================
  Files            70       70           
  Lines          7071     7071           
  Branches       1036     1036           
=========================================
  Hits           4203     4203           
  Misses         2563     2563           
  Partials        305      305           
Files Changed Coverage Δ
...hrifty/gradle/GenerateThriftSourcesWorkAction.java 0.00% <0.00%> (ø)

@benjamin-bader
Copy link
Collaborator

Thanks very much for the contribution!

@benjamin-bader benjamin-bader merged commit fc094d2 into microsoft:master Jul 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plugin ignores FieldNameStyle specification for Kotlin code gen
3 participants