Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VHR10 datamodule #1082

Merged
merged 33 commits into from
Jan 25, 2024
Merged

Add VHR10 datamodule #1082

merged 33 commits into from
Jan 25, 2024

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Feb 2, 2023

No description provided.

@github-actions github-actions bot added datamodules PyTorch Lightning datamodules scripts Training and evaluation scripts testing Continuous integration testing labels Feb 2, 2023
conf/vhr10.yaml Outdated Show resolved Hide resolved
@adamjstewart adamjstewart mentioned this pull request Feb 2, 2023
torchgeo/datamodules/vhr10.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart added this to the 0.5.0 milestone Feb 2, 2023
@calebrob6
Copy link
Member

@ashnair1 I can do this if you're busy

@ashnair1
Copy link
Collaborator Author

Appreciate it. Might be a while before I can get back to this.

@calebrob6
Copy link
Member

Same :)

@github-actions github-actions bot added datasets Geospatial or benchmark datasets trainers PyTorch Lightning trainers transforms Data augmentation transforms labels Apr 10, 2023
@ashnair1 ashnair1 marked this pull request as draft April 10, 2023 07:00
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a WIP but wanted to give intermediate feedback before you spend too long going in one direction.

torchgeo/transforms/transforms.py Show resolved Hide resolved
torchgeo/trainers/detection.py Outdated Show resolved Hide resolved
torchgeo/datamodules/vhr10.py Outdated Show resolved Hide resolved
torchgeo/datamodules/vhr10.py Outdated Show resolved Hide resolved
torchgeo/datamodules/vhr10.py Outdated Show resolved Hide resolved
torchgeo/datamodules/vhr10.py Outdated Show resolved Hide resolved
torchgeo/datamodules/vhr10.py Outdated Show resolved Hide resolved
torchgeo/datamodules/geo.py Outdated Show resolved Hide resolved
@adamjstewart
Copy link
Collaborator

Let me know if/when you want me to re-review. Otherwise I'll wait until the tests pass.

For the box format stuff, feel free to change things to match Kornia's expected format. Also see #985 for what I would like things to look like in the long-term.

@adamjstewart
Copy link
Collaborator

adamjstewart commented Jan 25, 2024

RtD CI will be fixed by #1827

Coverage drop is due to buggy codecov, rerunning minimum tests should fix that.

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are ways that this could be improved, but not without modifying kornia itself. I actually do want to do that someday, but we may also drop kornia entirely someday and switch back to torchvision-style transforms, so I'm not trying to rock the boat. This adds a much-needed VHR-10 data module, and the parts I'm uncertain about aren't public anyway, so I say we merge this and improve transform compatibility and sample consistency in the distant future.

@adamjstewart adamjstewart enabled auto-merge (squash) January 25, 2024 17:39
auto-merge was automatically disabled January 25, 2024 17:46

Pull request was closed

@adamjstewart adamjstewart reopened this Jan 25, 2024
@adamjstewart adamjstewart enabled auto-merge (squash) January 25, 2024 17:47
@adamjstewart adamjstewart merged commit 0f8b0ac into microsoft:main Jan 25, 2024
21 checks passed
@ashnair1 ashnair1 deleted the vhr10-datamodule branch February 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets testing Continuous integration testing transforms Data augmentation transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants