SSL4EO-L: add new dataset #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
commented
May 13, 2023
tests/datasets/test_ssl4eo.py
Outdated
| def dataset(self, monkeypatch: MonkeyPatch, request: SubRequest) -> SSL4EOS12: | ||
| monkeypatch.setitem( | ||
| monkeypatch.setitem( # type: ignore[arg-type] |
There was a problem hiding this comment.
| self.seasons = seasons | ||
| self.transforms = transforms | ||
|
|
||
| self.scenes = sorted(os.listdir(root)) |
There was a problem hiding this comment.
Will replace this with integer indexing after we remap the folder names.
torchgeo/datasets/ssl4eo.py
Outdated
Comment on lines
228
to
230
| _Metadata = TypedDict( | ||
| "_Metadata", {"filename": str, "md5": str, "bands": list[str]} | ||
| ) |
There was a problem hiding this comment.
TypedDict allows us to remove all uses of Any and cast! We should try to use this in more places.
| @@ -121,7 +298,7 @@ def __init__( | |||
| RuntimeError: if dataset is missing or checksum fails | |||
| """ | |||
| assert split in self.metadata | |||
| assert seasons in range(4) | |||
| assert seasons in range(1, 5) | |||
There was a problem hiding this comment.
This was a bug, oops
calebrob6
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining TODOs: