Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomGeoSampler: optional length is optional #1907

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

adamjstewart
Copy link
Collaborator

Not sure how no one noticed this bug in the past 2 years...

#755 made length optional for all samplers. We provided a default value of None for RandomBatchGeoSampler, but not RandomGeoSampler. This PR fixes it so the optional length is actually optional.

@adamjstewart adamjstewart added this to the 0.5.2 milestone Feb 25, 2024
@github-actions github-actions bot added the samplers Samplers for indexing datasets label Feb 25, 2024
@isaaccorley isaaccorley merged commit e9ae469 into microsoft:main Mar 2, 2024
24 checks passed
@adamjstewart adamjstewart deleted the fixes/sampler-length branch March 2, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samplers Samplers for indexing datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants