Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fields Of The World field boundary delineation dataset #2296

Merged
merged 22 commits into from
Sep 29, 2024
Merged

Add Fields Of The World field boundary delineation dataset #2296

merged 22 commits into from
Sep 29, 2024

Conversation

calebrob6
Copy link
Member

@calebrob6 calebrob6 commented Sep 15, 2024 •
edited
Loading

Dataset for field boundary delineation -- https://beta.source.coop/repositories/kerner-lab/fields-of-the-world/description/

Note: this PR adds the pyarrow dependency as this is needed by Pandas to read parquet files.

To-Do:

  • Dataset
  • Example plots
  • Fake data
  • Tests

image

image

image

@github-actions github-actions bot added documentation Improvements or additions to documentation datasets Geospatial or benchmark datasets labels Sep 15, 2024
@adamjstewart adamjstewart added this to the 0.7.0 milestone Sep 16, 2024
@adamjstewart
Copy link
Collaborator

Now we just need an instance segmentation trainer.

@github-actions github-actions bot added the dependencies Packaging and dependencies label Sep 20, 2024
calebrob6
calebrob6 commented Sep 20, 2024
View reviewed changes
requirements/min-reqs.old Outdated Show resolved Hide resolved
@github-actions github-actions bot added the testing Continuous integration testing label Sep 21, 2024
@calebrob6
Copy link
Member Author

Should be good for review now

adamjstewart
adamjstewart requested changes Sep 23, 2024
View reviewed changes
docs/api/datasets/non_geo_datasets.csv Show resolved Hide resolved
requirements/min-reqs.old Outdated Show resolved Hide resolved
tests/datasets/test_ftw.py Show resolved Hide resolved
requirements/min-reqs.old Outdated Show resolved Hide resolved
torchgeo/datasets/ftw.py Outdated Show resolved Hide resolved
torchgeo/datasets/ftw.py Outdated Show resolved Hide resolved
torchgeo/datasets/ftw.py Outdated Show resolved Hide resolved
torchgeo/datasets/ftw.py Outdated Show resolved Hide resolved
torchgeo/datasets/ftw.py Outdated Show resolved Hide resolved
torchgeo/datasets/ftw.py Outdated Show resolved Hide resolved
adamjstewart
adamjstewart previously approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor comment on unnecessary type hints, but this should be ready to go

@calebrob6 calebrob6 enabled auto-merge (squash) September 28, 2024 21:57
@calebrob6 calebrob6 closed this Sep 28, 2024
auto-merge was automatically disabled September 28, 2024 22:06

Pull request was closed

@calebrob6 calebrob6 reopened this Sep 28, 2024
@calebrob6 calebrob6 enabled auto-merge (squash) September 28, 2024 22:34
calebrob6
calebrob6 commented Sep 29, 2024
View reviewed changes
requirements/required.txt Outdated Show resolved Hide resolved
@calebrob6 calebrob6 merged commit b2f9936 into main Sep 29, 2024
19 checks passed
@calebrob6 calebrob6 deleted the fields_of_the_world branch September 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

@isaaccorley isaaccorley Awaiting requested review from isaaccorley

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets dependencies Packaging and dependencies documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@calebrob6 @adamjstewart