-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReforesTree dataset #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I like the object detection plotting.
Do you have an opinion about handling the download with Dropbox? Currently, it is not working and just throwing errors, so maybe there is a way around it or I write a description in the class for download instructions? |
It looks like the link you are using is auto generated by dropbox when you visit the current dataset download page -- https://www.dropbox.com/scl/fo/qzlq48k06dbksvrl3kk1o/h?dl=0&rlkey=hpq3r63b1tbpqa02f5tyh8l6s. I pinged to authors to see if they will host a single zip file for download (which we can easily download) / we can rehost on Zenodo. |
If it's not working I would remove all the download logic for now. We can add it in a new release if the authors are willing to host elsewhere. |
The authors responded to me and we should have a new link in a few days!
…On Mon, Jul 4, 2022, 8:54 AM Adam J. Stewart ***@***.***> wrote:
Do you have an opinion about handling the download with Dropbox?
Currently, it is not working and just throwing errors, so maybe there is a
way around it or I write a description in the class for download
instructions?
If it's not working I would remove all the download logic for now. We can
add it in a new release if the authors are willing to host elsewhere.
—
Reply to this email directly, view it on GitHub
<#582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJUTWMZUKVTEIOQOSSI3LVSMCKNANCNFSM5Y2YA5JA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Let's wait then. I don't think we're going to finish 0.3.0 this weekend, going to have to push it to next weekend until we have a chance to resolve these CI issues. |
Is the MD5 the same? EDIT: downloading now to check |
Yep! I confirmed on zenodo (they compute md5s). I'll see why these are
failing in a bit.
…On Sat, Jul 9, 2022, 9:08 AM Adam J. Stewart ***@***.***> wrote:
Is the MD5 the same?
—
Reply to this email directly, view it on GitHub
<#582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJUTQYQOAEZ63IPQR3JZTVTGPWFANCNFSM5Y2YA5JA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have a bunch of edits, but I'll just push them myself |
* add ReforesTree dataset * fix failing test * suggested changes * Update download URL * Change zipfile name * Minor fixes * Remove f-string * Fix dtype, remove unnecessary conversion Co-authored-by: Caleb Robinson <calebrob6@gmail.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
This PR adds ReforestTree dataset for tree crown detection and aboveground biomass (AGB) estimation from the ReforesTree paper. The
__getitem__
method returns images, boxes, tree species labels, and AGB values.Features:
Issue:
Example: