Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type source info for value type #82

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Add type source info for value type #82

merged 3 commits into from
Nov 8, 2021

Conversation

zhuorantan
Copy link
Contributor

@zhuorantan zhuorantan commented Nov 8, 2021 •
edited
Loading

Add isFromParameter and isFromReturn to InterfaceView and EnumView to indicate where the value type is extracted.

@zhuorantan zhuorantan enabled auto-merge (squash) November 8, 2021 04:38
Foolment
Foolment approved these changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@Foolment Foolment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuorantan zhuorantan merged commit fd220da into microsoft:main Nov 8, 2021
@zhuorantan zhuorantan deleted the zhutan/add-type-source branch November 8, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foolment Foolment Foolment approved these changes

@imWildCat imWildCat Awaiting requested review from imWildCat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuorantan @Foolment