Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral buffer hardening #160

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Conversation

johnstairs
Copy link
Member

  1. Use HTTP trailers to signal an error to the client when an error occurs when reading the named pipe in the buffer sidecar
  2. Return response headers as soon as possible from relay server to avoid client timeouts
  3. Improve error messages for common error cases.

@hansenms hansenms requested a review from Copilot December 12, 2024 18:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

cli/cmd/buffer-sidecar/main.go:115

  • Spelling mistake in the comment: 'listner' should be 'listener'.
// give some time for a client to connect and pass in the data that will be discarded instead of just closing the listner.

cli/cmd/buffer-sidecar/main.go:182

  • Spelling mistake in the comment: 'reponse' should be 'response'.
// give some time for a client to connect and observe the empty reponse instead of just closing the listener
@johnstairs johnstairs merged commit 5298008 into main Dec 12, 2024
16 checks passed
@johnstairs johnstairs deleted the johnstairs/harden-ephemeral-buffers branch December 12, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants