Support custom installation path for Docker mode #163
Conversation
| as query parameters (after the `?`). These are: | ||
| your SSH config file (~/.ssh/config). The API socket path can be omitted if the | ||
| socket path is the default `/opt/tyger/api.sock` or if the `TYGER_SOCKET_PATH` | ||
| environment variable is set on the SSH host. |
There was a problem hiding this comment.
We could also use the environment variable on the client. Thoughts?
There was a problem hiding this comment.
I think that might be getting too clever about it, since one could have a local docker install in addition to the remote. I think it is fine the way it is. Is it possible to specify TYGER_SOCKET_PATH as one of the key value pairs? Then what happens if they are not consistent? I am assuming it is not possible, so a non-issue.
There was a problem hiding this comment.
It is not currently possible to specify it as a key-value pair. Instead, you give the path to the socket as the path in the URL.
johnstairs
changed the title
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated 3 suggestions.
Files not reviewed (15)
- .devcontainer/devcontainer.json: Language not supported
- .devcontainer/prepare-host.sh: Language not supported
- .vscode/launch.json: Language not supported
- Makefile.docker: Language not supported
- install/.gitignore: Language not supported
- scripts/get-config.sh: Language not supported
- scripts/run-ssh-tests.sh: Language not supported
- cli/integrationtest/migrations_test.go: Evaluated as low risk
- cli/internal/client/client.go: Evaluated as low risk
- cli/internal/client/client_test.go: Evaluated as low risk
- cli/internal/client/sshurl.go: Evaluated as low risk
- cli/internal/cmd/stdioproxy.go: Evaluated as low risk
- cli/internal/controlplane/login.go: Evaluated as low risk
- cli/internal/install/dockerinstall/docker.go: Evaluated as low risk
- cli/internal/install/dockerinstall/migrations.go: Evaluated as low risk
Allow specifying the installation path for Docker mode.