Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mention of node 4 support #335

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Removed mention of node 4 support #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f153c9f
Remove mention of node 4 support from README
KonstantinTyukalov Jul 18, 2022
5d9c88b
Remove mention of node 4 support from CONTRIBUTING
KonstantinTyukalov Jul 18, 2022
a345edf
Add mention about node16 testing
KonstantinTyukalov Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ To build and test you need LTS Node >= 6.12.0 and Npm 5.5.1 (we use lock files).
For contributions, we recommend using Node 10.15.1 and Npm 6.9.0 in order to minimize friction between package-lock formatting.

## Build

```
$ npm install
$ npm run build
```

## Test

You should test with node 4.x, 6.x and 8.x LTS. We recommend using nvm ([linux](https://github.com/creationix/nvm) / [windows](https://github.com/coreybutler/nvm-windows))
You should test with node 6.x, 8.x and 16.x LTS. We recommend using nvm ([linux](https://github.com/creationix/nvm) / [windows](https://github.com/coreybutler/nvm-windows))

```
npm test
Expand Down
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,9 @@ or
set NODE_DEBUG=http
```



## Node support

The typed-rest-client is built using the latest LTS version of Node 8. We also support the latest LTS for Node 4 and Node 6.
The typed-rest-client is built using the latest LTS version of Node 8. We also support the latest LTS for Node 6 and newer.

## Contributing

Expand Down