This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Don't double-prefix version directory name #739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool - this explains DefinitelyTyped/DefinitelyTyped#42377 - /cc @alloy @sandersn |
|
@jablko Was this fix indeed made for the CODEOWNERS file or for failing CI builds such as https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/651445339#L500 ? |
|
I’m going to create another PR that also adds test coverage. |
|
Created #741. Alas I wasn’t able to verify if this fixes the CI build failure that I linked to. |
|
Looks like it did: https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/651445339#L500 |
|
Yep, you pulled the fix commit into #741 as I recall. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this change,
pkg.subDirectoryPathreturns paths likenode/vv10.