No code frame synthetic (#2565)

fix [#2448](#2448) --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
microsoft · Oct 13, 2023 · 897507d · 897507d
1 parent 1599bdd
commit 897507d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/common/changes/@typespec/compiler/no-code-frame-synthetic_2023-10-11-20-31.json b/common/changes/@typespec/compiler/no-code-frame-synthetic_2023-10-11-20-31.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@typespec/compiler",
+      "comment": "Stop showing empty code frame when diagnostic has no location",
+      "type": "none"
+    }
+  ],
+  "packageName": "@typespec/compiler"
+}
diff --git a/packages/compiler/src/core/logger/console-sink.ts b/packages/compiler/src/core/logger/console-sink.ts
@@ -71,7 +71,7 @@ function formatSourceLocation(options: FormatLogOptions, location: SourceLocatio
  *   9 | op doBeta(@path id: string): string;
  */
 function formatSourcePreview(options: FormatLogOptions, location: SourceLocation) {
-  if (!options.pretty) {
+  if (!options.pretty || location.isSynthetic) {
     return "";
   }
   const postion = getLineAndColumn(location);