Samples as tests #2215
Merged
Samples as tests #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2215/ |
timotheeguerin
commented
Jul 28, 2023
There was a problem hiding this comment.
Rename of the files is due to it including the emitter name in the output path (Default output-dir)
So it goes from
-/test/output/authentication/openapi.yaml
+/test/output/authentication/@typespec/openapi3/openapi.yamlThis is useful if we want to run multiple emitters for the same sample which is something we do in the typespec-azure repo where is a lot of rename as well https://github.com/Azure/typespec-azure/pull/3337
timotheeguerin
commented
Jul 28, 2023
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
timotheeguerin
commented
Jul 28, 2023
There was a problem hiding this comment.
I can move this new util into a dedicated PR if people prefer for the review.
markcowl
requested changes
Aug 1, 2023
markcowl
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3017
Run the samples as test which allows all of them to run without crashing on the first one, lets us run it in the test explorer.
This also make the sample regeneration much faster(typespec azure repo):
~90s~12sNew
resolveCompilerOptionsutilsThis also include the addition of a new util
resolveCompilerOptionsthat resolve the compiler options programtically in the same way that the cli would have for a given entrypoint.I can move this into a dedicated PR if people prefer.