-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Xml library #3035
Feature: Add Xml library #3035
Conversation
All changed packages have been documented. |
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3035/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3035/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits.
@timotheeguerin do we have any plans for CDATA support or would that be intrinsic to the encoding and decoding to decide whether one belongs? For example, Notification Hubs stores various things in CDATA sections such as template bodies and other information. Or is that a follow on item to this? |
Yeah this was left as a follow up, or as a serializer job. Current goal was to get parity with openapi for now. If you have some particular idea in mind on how specifying some data info would cover some use cases I would file a new issue with the example. |
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
Add xml library following the approved design.
fix #2970
Only minor change was inverting the parmaeters for
@ns(namespace, prefix
instead of@namespace(prefix, namespace)
which makes it clearer with the other overload@ns(namespace: EnumMember)