Set Installed to false inside uplugin

[linqen]

This will avoid the engine asking every time you open it to update the uproject file with the new plugins.

If we update the project file with this change, not having the plugin installed will block other team members to build the game because the missing dependency.

This plugin is a Tool, but not a requirement, so it shouldn't be a dependency, therefore it shouldn't be added to .uproject by default

[linqen]

@LukaszMendakiewicz @DavidARaygoza Hey, this is a small fix/improvement that is affecting my team and I'm very sure a lot of people using it. Could you take a look at it please? :)

[LukaszMendakiewicz]

Hey @linqen - thanks for the ping and apologies for the delay.
I am not sure of the full implications of this change - the documentation is quite light on the property - so I would prefer to hold a little more for @hnrqbaggio to take a look once he is back from the break. We should be able to circle back to you by the end of the month.

[linqen]

Great, thank you very much for your answer on this.

The best information I could find about this is this:

In GameProjectUtils.cpp::CheckForOutOfDateGameProjectFile(), it will check for out of date game project file, and decides that based on Plugin->GetDescriptor().bInstalled

// Check if there are any installed plugins that need to be added as a reference
TArray<FPluginReferenceDescriptor> NewPluginReferences = Project->Plugins;

for(TSharedRef<IPlugin>& Plugin: IPluginManager::Get().GetEnabledPlugins())
{
	if(Plugin->GetDescriptor().bInstalled && Project->FindPluginReferenceIndex(Plugin->GetName()) == INDEX_NONE)
	{
		FPluginReferenceDescriptor PluginReference(Plugin->GetName(), true);
		NewPluginReferences.Add(PluginReference);
		bRequiresUpdate = true;
	}
}

FindPluginReferenceIndex will try to find this plugin by name on the already added plugins.
Most of the plugins I found around the engine, are Installed = false.

I hope this helps!

[hnrqbaggio]

Thank you for the contribution, @linqen.

I've looked at the docs and the code that is using the field. It seems indeed that for our case it should be set to false.

Approved.