Take account of any core redirects for the blueprint classes we want to scan. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take account of any core redirects for the blueprint classes we want to scan.
hnrqbaggio
suggested changes
Feb 14, 2024
There was a problem hiding this comment.
Thank you for the contribution @markdotai!
There are a few small adjustments that would be interesting to make. Let us know if you have any questions.
Source/VisualStudioTools/Private/VisualStudioToolsCommandlet.cpp
Outdated
Show resolved
Hide resolved
Source/VisualStudioTools/Private/VisualStudioToolsCommandlet.cpp
Outdated
Show resolved
Hide resolved
Improvements to the core redirects asset filter building
hnrqbaggio
approved these changes
Feb 16, 2024
|
@markdotai it seems you need to confirm the CLA before I merge the changes. Not sure why it's asking again you you've contributed that other PR already, but can you try to run the steps the bot is requesting again? |
|
@microsoft-github-policy-service agree company="Smilegate Barcelona S.L." |
|
Thanks @hnrqbaggio! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we had some class redirects set up in DefaultEngine.ini, e.g.:
+ClassRedirects=(OldName="TempAbilityCrouch",NewName="AbilityCrouch")
And we had some blueprint classes which were child classes of the old name and had not yet been recompiled and saved (to force them to update to the new redirected name).
And these blueprint classes were not showing up via VisualStudioTools.
I don't know what the "/Script/CoreUObject.Class" section is in the class name strings - but it seems required and seems to work ...