Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UVSServerCommandlet for VS Unreal Engine Server Mode #34

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

DavidARaygoza
Copy link
Member

@DavidARaygoza DavidARaygoza commented Nov 27, 2023

Detailed description can be found here: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullrequest/512789

This PR creates a new server commandlet that starts an infinite loops which every second will try to create a connection with the named pipe passed in. If a connection is successfully created then we use the params passed into the pipe to invoke the appropriate subcommandlet and write back a result response to the pipe so that the flow can continue on the Visual studio side.

@DavidARaygoza DavidARaygoza force-pushed the dev/davidraygoza/UVSServerCommandlet branch from f6e8554 to c863ea4 Compare December 1, 2023 22:59
@DavidARaygoza DavidARaygoza marked this pull request as ready for review December 5, 2023 20:21
Copy link
Contributor

@hnrqbaggio hnrqbaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DavidARaygoza DavidARaygoza force-pushed the dev/davidraygoza/UVSServerCommandlet branch from c863ea4 to 16993d4 Compare December 8, 2023 02:37
@DavidARaygoza DavidARaygoza merged commit acbd32f into main Dec 8, 2023
2 checks passed
@DavidARaygoza DavidARaygoza deleted the dev/davidraygoza/UVSServerCommandlet branch December 8, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants