Rename / Rearrange BinaryCache functions #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
reviewed
May 6, 2023
BillyONeal
approved these changes
May 8, 2023
autoantwort
reviewed
May 30, 2023
| @@ -552,8 +551,6 @@ namespace vcpkg | |||
| perform_install_plan_action(args, paths, action, status_db, binary_cache, build_logs_recorder)); | |||
| } | |||
|
|
|||
| compute_all_abis(paths, action_plan, var_provider, status_db); | |||
| binary_cache.prefetch(action_plan.install_actions); | |||
There was a problem hiding this comment.
Now the prefetch is done before Install::execute_plan, but in line 544/543 the packages folder is removed.
There was a problem hiding this comment.
Those lines are only relevant for packages that are being removed.
There was a problem hiding this comment.
But if a package gets reinstalled with a different feature set it gets removed and then installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts ancillary changes from #998 so they can be reviewed separately from the primary rewrite of binarycaching.cpp.
create_binary_providers_from_configs_pure->parse_binary_provider_configsDifferent callers of
Install::performperformed different amounts of "prep" (computing ABIs, etc). This work was then repeated insideperform.To resolve this, all callers are now expected to compute all ABIs ahead of time. I've removed the
var_providerparameter, and made theactionparameterconst.I've lifted the
REQUIRE_LINEStest macro so it can be used in more places.