Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More expressive checks in triplet #1379

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Thomas1664
Copy link
Contributor

This makes it more clear what is actually checked here.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes other than is_overlay_port look good to me.

include/vcpkg/sourceparagraph.h Outdated Show resolved Hide resolved
@Thomas1664 Thomas1664 requested a review from BillyONeal April 25, 2024 06:57
@BillyONeal BillyONeal marked this pull request as draft May 29, 2024 00:04
@Thomas1664 Thomas1664 marked this pull request as ready for review December 8, 2024 16:42
@Thomas1664 Thomas1664 requested a review from BillyONeal December 8, 2024 17:02
@Thomas1664 Thomas1664 changed the title More expressive checks in triplet/port More expressive checks in triple Dec 8, 2024
@Thomas1664 Thomas1664 changed the title More expressive checks in triple More expressive checks in triplet Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants