Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VCPKG_SCRIPTS_DIR and VCPKG_TOOLS_DIR to the CMake command call #1420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add VCPKG_SCRIPTS_DIR and VCPKG_TOOLS_DIR to the CMake command call #1420

wants to merge 2 commits into from

Conversation

Neumann-A
Copy link
Contributor

To make stuff mentioned in #1315 (comment) not magically (and maybe even wrongly) calculate those paths.

Neumann-A
Neumann-A commented Jun 10, 2024
View reviewed changes
src/vcpkg/buildenvironment.cpp Outdated
@@ -17,6 +17,8 @@ namespace vcpkg
local_variables.emplace_back("BUILDTREES_DIR", paths.buildtrees());
local_variables.emplace_back("_VCPKG_INSTALLED_DIR", paths.installed().root());
local_variables.emplace_back("DOWNLOADS", paths.downloads);
local_variables.emplace_back("VCPKG_SCRIPTS_DIR", paths.scripts);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be just SCRIPTS since it is already defined in ports.cmake ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me

@BillyONeal
Copy link
Member

Alternately I think --x-scripts-root should die because there is no safe way for it to be used at present.

@Neumann-A
Copy link
Contributor Author

Alternately I think --x-scripts-root should die because there is no safe way for it to be used at present.

Please explain

@BillyONeal
Copy link
Member

Alternately I think --x-scripts-root should die because there is no safe way for it to be used at present.

Please explain

The only acceptable content for the scripts tree is the same content that matches the copy of vcpkg, the tool, itself. There is no meaning to the user trying to replace where that is, the only reason the switch exists has long gone.

@Neumann-A
Copy link
Contributor Author

Alternately I think --x-scripts-root should die because there is no safe way for it to be used at present.

Please explain

The only acceptable content for the scripts tree is the same content that matches the copy of vcpkg, the tool, itself.

I am still missing the why explanation here. So I still need a sentence which starts something like "because otherwise ...." or something logically similar.

Whatever the decision about the cli switch this PR just passes down internal path knowledge. If this is scripts dir or the dir of the cmake entry point (ports.cmake) with the scripts subfolder added doesnt really matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neumann-A @BillyONeal